core: adapt to datascript Int64 values (pin e439cba) - #26
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Datascript upstream c39cad1 changed value Int of int to Int64 of int64. Convert at the boundary: chat domain types stay int, wrapped via Int64.of_int/Int64.to_int; test literals get the L suffix; sync codec emits Transit.Int64 unconditionally like upstream. file/created-at and file/last-modified-at are written as Int64 rather than Instant since upstream now demotes Instant to Int64 for attrs without :db.type/instant on storage read.
devin-ai-integration
Bot
force-pushed
the
devin/datascript-int64-adapt
branch
from
September 26, 2026 13:58
313335c to
2bf4441
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Datascript upstream
c39cad1changedvalue'sInt of inttoInt64 of int64(merged ase439cbain logseq/datascript-ocaml). Main's#mainpin picked it up mid-run and broke CI; this PR adapts chat's ~105Ds.Intcall sites and repins datascript toe439cba.Conversion convention: chat-side domain types stay
int; wrap at theDs.Int64boundary withInt64.of_int/Int64.to_int. Test literals use theLsuffix. Entity ids remainint(Ds.Ref/Ref_toare unchanged upstream).Notable non-mechanical bits:
storage_codec.ml:Value.Int/Int64/Big_intall encode toDs.Int64; decode acceptsTransit.Int,Int64, andBig_int;Ds.Instantround-trips throughTagged ("m", ...).sync_tx.ml: emitsTransit.Int64unconditionally (upstream sends Int64 on the wire).cache_model.mlint_decode:Ds.Int64 → Int64.to_int, keepingcreated_at : intetc.graph_bootstrap.ml:file/created-atandfile/last-modified-atnow writeDs.Int64instead ofDs.Instant— upstreamstorage.mldemotesInstanttoInt64on read for attrs without:db.type/instant, so storingInstantthere no longer round-trips.Ds.Ref eid | Ds.Int eidwere split into separate branches sinceRefstaysintwhileInt64isint64.Supersedes #25 (this branch contains its pin commit, then repins to
e439cba).Local:
dune build @shared/native/runtest— 717 tests, all green.Link to Devin session: https://app.devin.ai/sessions/9a91e201984a4d4f96ce3e0f86ac6668
Open in Devin Desktop: https://app.devin.ai/desktop/session/9a91e201984a4d4f96ce3e0f86ac6668?variant=devin
Requested by: @tiensonqin